[MIRROR] Records Blackbox Feedback on Items used to Suicide #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RE] (#25590) * Records Blackbox Feedback on Items used to Suicide * Update _logging.dm --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: Bloop <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Fixes Summon Simian spell killing you as a monkey (#81619) ## About The Pull Request The old logic worked like this: It checked for monkey faction (good), however, monkey faction is given to roundstart monkey human subtypes (bad) instead of using the inherent_factions variable on the species. ## Why It's Good For The Game A spell advertised as not backfiring if you're a monkey should probably not backfire if you're a monkey ## Changelog :cl: fix: The Summon Simians spell will now properly check for monkey faction, allowing people who are monkeys to not be mauled. /:cl: * Fixes Summon Simian spell killing you as a monkey --------- Co-authored-by: SgtHunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25590
Original PR: tgstation/tgstation#80258
About The Pull Request
On the tin, we just record the
typeof the item that the human may be holding while they try and commit suicide with it. Useful for knowing what people are:A) killing themselves with
B) trying to kill themselves with
i just think it's neat data
Changelog
doesn't matter