Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds basic mobs to "fancy types" (spawn atom window type-shortener) #1100

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25595
Original PR: tgstation/tgstation#80192

About The Pull Request

Basically in the spawn window instead of writing out something like /mob/living/basic/heretic/thingamcdohicker/lesser it will now prepend to BASIC/heretic/thingamcdochiker/lesser which is quite a bit better imo.

Here's a screenshot that should summarize it a bit better:

image

Why It's Good For The Game

we do the same thing for simple animals since those can also have pretty long typepaths/subtype trees so it's probably a good idea to add this case in as well while we're converting everything over.

Changelog

🆑 san7890
qol: For admins, in the "Spawn Atom" window where you pick atoms to spawn-by-type, anything that is a subtype of /mob/living/basic should now be replaced with the BASIC tag instead (like with carbons, reagent containers, turfs, etc.). So, instead of having to scroll through and try and figure out what that weird subtype of Poly is, it should now be easier to read in that smaller screen.
/:cl:

…rtener) [MDB IGNORE] (#25595)

* Adds basic mobs to "fancy types" (spawn atom window type-shortener) (#80192)

## About The Pull Request

Basically in the spawn window instead of writing out something like
`/mob/living/basic/heretic/thingamcdohicker/lesser` it will now prepend
to `BASIC/heretic/thingamcdochiker/lesser` which is quite a bit better
imo.

Here's a screenshot that should summarize it a bit better:

![image](https://github.com/tgstation/tgstation/assets/34697715/fcb4cadb-1e90-49fb-8bd7-c187a4d454fa)
## Why It's Good For The Game

we do the same thing for simple animals since those can also have pretty
long typepaths/subtype trees so it's probably a good idea to add this
case in as well while we're converting everything over.
## Changelog
:cl:
qol: For admins, in the "Spawn Atom" window where you pick atoms to
spawn-by-type, anything that is a subtype of `/mob/living/basic` should
now be replaced with the `BASIC` tag instead (like with carbons, reagent
containers, turfs, etc.). So, instead of having to scroll through and
try and figure out what that weird subtype of Poly is, it should now be
easier to read in that smaller screen.
/:cl:

* Adds basic mobs to "fancy types" (spawn atom window type-shortener)

---------

Co-authored-by: san7890 <[email protected]>
@Iajret Iajret merged commit 24c6fb2 into master Dec 14, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25595 branch December 14, 2023 00:24
AnywayFarus added a commit that referenced this pull request Dec 14, 2023
Iajret pushed a commit that referenced this pull request Feb 23, 2024
… put jackets and armor vests and such) because it was causing weird sprite problems (#1100)

she got too silly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants