[MIRROR] Prevents something fucky with elevation and glass tables #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B IGNORE] (#25567) * Prevents something fucky with elevation and glass tables (#80187) ## About The Pull Request Objects can be destroyed during a movement loop before the abstract entered signal can be sent, so we need to make sure only mobs that have been elevated are dropped down. ## Why It's Good For The Game Fixes #80169 ## Changelog :cl: fix: climbing or being shoved into a glass table won't cause elevation issues. /:cl: --------- Co-authored-by: san7890 <the@ san7890.com> * Prevents something fucky with elevation and glass tables --------- Co-authored-by: Ghom <[email protected]> Co-authored-by: san7890 <the@ san7890.com>
AnywayFarus
added a commit
that referenced
this pull request
Dec 12, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 21, 2024
…efs to not function (#1083) * Fix dead mobs changing their mob `tag` causing obsever weakrefs to not function (#81585) ## About The Pull Request Fixes #81578 Fixes #81559 Fixes #81308 In #69634 mob tag generation was moved to `/mob/New` But dead mobs also do this in initialize  So dead mobs skipped over a tag This is whatever, until it's not: If something makes a weakref of an observer in `/observer/Initialize` before its parent call, which shuffles the mob tag around, uh oh now our weakref points to a non-existent ref! So what's making the weakref? No clue but apparently chasms ## Changelog :cl: Melbert fix: Chasms no longer break your verbs /:cl: * Fix dead mobs changing their mob `tag` causing obsever weakrefs to not function --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25567
Original PR: tgstation/tgstation#80187
About The Pull Request
Objects can be destroyed during a movement loop before the abstract entered signal can be sent, so we need to make sure only mobs that have been elevated are dropped down.
Why It's Good For The Game
Fixes #80169
Changelog
🆑 Ghommie
fix: climbing or being shoved into a glass table won't cause elevation issues.
/:cl: