Skip to content

Commit

Permalink
fixes some dynamic rulesets purging their candidate pools (#87760)
Browse files Browse the repository at this point in the history
## About The Pull Request
autotator, malf and blob's candidates would all get wiped out by this,
as `can_roll_midround()` returns TRUE if they can roll midround

## Why It's Good For The Game
seems like we want candidates in these roles, given the game is trying
to get some

## Changelog
:cl:
fix: dynamic rulesets can get candidates for their roles
/:cl:
fixes #87535
  • Loading branch information
harryob authored and Iajret committed Dec 6, 2024
1 parent 9d78e61 commit fb1be37
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@
candidates -= player
else if(is_centcom_level(player.z))
candidates -= player // We don't autotator people in CentCom
else if(player.mind && (player.mind.special_role || player.mind.can_roll_midround()))
else if(player.mind && (player.mind.special_role || !player.mind.can_roll_midround()))
candidates -= player // We don't autotator people with roles already
//NOVA EDIT ADDITION
else if(player in rejected_traitor)
Expand Down Expand Up @@ -330,7 +330,7 @@
continue
if(isnull(player.mind))
continue
if(player.mind.special_role || player.mind.can_roll_midround())
if(player.mind.special_role || !player.mind.can_roll_midround())
continue
candidates += player

Expand Down Expand Up @@ -499,7 +499,7 @@
candidates -= player
continue

if(player.mind && (player.mind.special_role || player.mind.can_roll_midround()))
if(player.mind && (player.mind.special_role || !player.mind.can_roll_midround()))
candidates -= player

/datum/dynamic_ruleset/midround/from_living/blob_infection/execute()
Expand Down

0 comments on commit fb1be37

Please sign in to comment.