Skip to content

Commit

Permalink
[MIRROR] Borg movement now has sounds (#2090)
Browse files Browse the repository at this point in the history
* Borg movement now has sounds (#82704)

## About The Pull Request
adds sound effects to cyborgs when they move
Demo: 
https://imgur.com/a/7Mu98pQ

Open to feedback on this sound so please tell me what you think.
## Why It's Good For The Game
a hunk of metal moving at you without any sound is frightening
## Changelog
:cl: grungussuss
sound: cyborgs now have sounds to indicate they are moving
/:cl:

* Borg movement now has sounds

---------

Co-authored-by: Sadboysuss <[email protected]>
  • Loading branch information
2 people authored and StealsThePRs committed Apr 22, 2024
1 parent ae5d496 commit f9edbda
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 0 deletions.
1 change: 1 addition & 0 deletions code/__DEFINES/footsteps.dm
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#define FOOTSTEP_MOB_RUST "footstep_rust"
#define FOOTSTEP_OBJ_MACHINE "footstep_machine"
#define FOOTSTEP_OBJ_ROBOT "footstep_robot"
#define FOOTSTEP_OBJ_CYBORG_TRACK "footstep_cyborg_track"

//priority defines for the footstep_override element
#define STEP_SOUND_NO_PRIORITY 0
Expand Down
4 changes: 4 additions & 0 deletions code/datums/elements/footstep.dm
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
footstep_sounds = 'sound/effects/bang.ogg'
RegisterSignal(target, COMSIG_MOVABLE_MOVED, PROC_REF(play_simplestep_machine))
return
if(FOOTSTEP_OBJ_CYBORG_TRACK)
footstep_sounds = 'sound/effects/footstep/cyborg_track.ogg'
RegisterSignal(target, COMSIG_MOVABLE_MOVED, PROC_REF(play_simplestep_machine))
return
if(FOOTSTEP_OBJ_ROBOT)
footstep_sounds = 'sound/effects/tank_treads.ogg'
RegisterSignal(target, COMSIG_MOVABLE_MOVED, PROC_REF(play_simplestep_machine))
Expand Down
1 change: 1 addition & 0 deletions code/modules/mob/living/silicon/robot/robot.dm
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

set_wires(new /datum/wires/robot(src))
AddElement(/datum/element/empprotection, EMP_PROTECT_WIRES)
AddElement(/datum/element/footstep, footstep_type = FOOTSTEP_OBJ_CYBORG_TRACK)
AddElement(/datum/element/ridable, /datum/component/riding/creature/cyborg)
RegisterSignal(src, COMSIG_PROCESS_BORGCHARGER_OCCUPANT, PROC_REF(charge))
RegisterSignal(src, COMSIG_LIGHT_EATER_ACT, PROC_REF(on_light_eater))
Expand Down
6 changes: 6 additions & 0 deletions sound/attributions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,9 @@ https://freesound.org/people/gynation/sounds/82378/
nightmare_poof.ogg and nightmare_reappear.ogg are comprised of breath_01.wav by Nightflame (CC0) and slide-click.wav by Qat (CC0)
https://freesound.org/people/Qat/sounds/108332/
https://freesound.org/people/Nightflame/sounds/368615/

cyborg_track.ogg is made by grungussuss From the following sounds: https://freesound.org/people/Ubehag/sounds/235350/ ; https://freesound.org/people/walthamstow_walker/sounds/559491/ ; https://freesound.org/people/Artninja/sounds/701459/ ; https://freesound.org/people/Garuda1982/sounds/541240/
under this license: https://creativecommons.org/licenses/by/4.0/



Binary file added sound/effects/footstep/cyborg_track.ogg
Binary file not shown.

0 comments on commit f9edbda

Please sign in to comment.