Skip to content

Commit

Permalink
[MIRROR] Removes overly optimistic warn on byond version (#701) (#1770)
Browse files Browse the repository at this point in the history
* Removes overly optimistic warn on byond version (#81185)

## About The Pull Request

I assumed this would be fixed because I assumed it was a bug. My report
goes unresponded to.

* Removes overly optimistic warn on byond version

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: LemonInTheDark <[email protected]>
  • Loading branch information
3 people authored Feb 1, 2024
1 parent 09f80d4 commit d513c01
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions code/controllers/globals.dm
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ GLOBAL_REAL(GLOB, /datum/controller/global_vars)

var/datum/controller/exclude_these = new
// I know this is dumb but the nested vars list hangs a ref to the datum. This fixes that
// I have an issue report open, lummox has not responded. It might be a FeaTuRE
// Sooo we gotta be dumb
var/list/controller_vars = exclude_these.vars.Copy()
controller_vars["vars"] = null
gvars_datum_in_built_vars = controller_vars + list(NAMEOF(src, gvars_datum_protected_varlist), NAMEOF(src, gvars_datum_in_built_vars), NAMEOF(src, gvars_datum_init_order))

#if MIN_COMPILER_VERSION >= 515 && MIN_COMPILER_BUILD > 1620
#warn datum.vars hanging a ref should now be fixed, there should be no reason to remove the vars list from our controller's vars list anymore
#endif
QDEL_IN(exclude_these, 0) //signal logging isn't ready

Initialize()
Expand Down

0 comments on commit d513c01

Please sign in to comment.