Skip to content

Commit

Permalink
[MIRROR] Fix last words being double-encoded when done from the alert…
Browse files Browse the repository at this point in the history
… popup (#1921)

* Fix last words being double-encoded when done from the alert popup (#81386)

## About The Pull Request

Fixes succumb last words, when typed in the tgui input popup, being
double-encoded/sanitized, resulting in things like this:

Upstream port of
Monkestation/Monkestation2.0#1182

## Why It's Good For The Game

This bug is annoying and makes text uglier and less readable. Also, bugs
are bad. Do I even need to fill this part out for a blatant bugfix?

* Fix last words being double-encoded when done from the alert popup

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Lucy <[email protected]>
  • Loading branch information
3 people authored Feb 10, 2024
1 parent a25f372 commit ca3ccae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion code/_onclick/hud/alert.dm
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ or shoot a gun to move around via Newton's 3rd Law of Motion."
var/mob/living/living_owner = owner
var/last_whisper
if(!HAS_TRAIT(living_owner, TRAIT_SUCCUMB_OVERRIDE))
last_whisper = tgui_input_text(usr, "Do you have any last words?", "Goodnight, Sweet Prince")
last_whisper = tgui_input_text(usr, "Do you have any last words?", "Goodnight, Sweet Prince", encode = FALSE) // saycode already handles sanitization
if(isnull(last_whisper))
if(!HAS_TRAIT(living_owner, TRAIT_SUCCUMB_OVERRIDE))
return
Expand Down

0 comments on commit ca3ccae

Please sign in to comment.