Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Iajret authored Dec 19, 2024
1 parent d9a659f commit b8e6a41
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
7 changes: 4 additions & 3 deletions code/modules/admin/admin.dm
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
////////////////////////////////
/proc/message_admins(msg, not_to_eventmaker)
/proc/message_admins(msg, not_to_eventmaker) // TFF EDIT. ORIGINAL /proc/message_admins(msg)
msg = "<span class=\"admin\"><span class=\"prefix\">ADMIN LOG:</span> <span class=\"message\">[msg]</span></span>"
// TFF CHANGE START - EVENTMAKERS
var/list/addressee = GLOB.admins.Copy()
if(not_to_eventmaker)
for(var/client/admin in GLOB.admins)
if(admin.is_eventmaker())
addressee -= admin

to_chat(addressee,
// TFF CHANGE END
to_chat(addressee, // TFF EDIT. ORIGINAL GLOB.admins,
type = MESSAGE_TYPE_ADMINLOG,
html = msg,
confidential = TRUE)
Expand Down
8 changes: 4 additions & 4 deletions code/modules/admin/verbs/secrets.dm
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w
var/client/holder //client of whoever is using this datum
var/is_debugger = FALSE
var/is_funmin = FALSE
var/is_eventmaker_admin = FALSE
var/is_eventmaker_admin = FALSE // TFF EDIT - Eventmaker

/datum/secrets_menu/New(user)//user can either be a client or a mob due to byondcode(tm)
if (istype(user, /client))
Expand All @@ -21,8 +21,8 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w

is_debugger = check_rights(R_DEBUG)
is_funmin = check_rights(R_FUN)
is_eventmaker_admin = holder.is_eventmaker()
world.log << is_eventmaker_admin
is_eventmaker_admin = holder.is_eventmaker() // TFF EDIT - Eventmaker
world.log << is_eventmaker_admin // TFF EDIT - Eventmaker

/datum/secrets_menu/ui_state(mob/user)
return GLOB.admin_state
Expand All @@ -40,7 +40,7 @@ ADMIN_VERB(secrets, R_NONE, "Secrets", "Abuse harder than you ever have before w
var/list/data = list()
data["is_debugger"] = is_debugger
data["is_funmin"] = is_funmin
data["is_eventmaker"] = is_eventmaker_admin
data["is_eventmaker"] = is_eventmaker_admin // TFF EDIT - Eventmaker
return data

#define THUNDERDOME_TEMPLATE_FILE "admin_thunderdome.dmm"
Expand Down

0 comments on commit b8e6a41

Please sign in to comment.