[MIRROR] Comprehensive cleanup of storage datum, replaces the weakref…

…s with just refs (because they were managed already) (#785) * Comprehensive cleanup of storage datum, replaces the weakrefs with just refs (because they were managed already) * CI fix * Clean up modular items * Surgery Tray Fix --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
Fluffy-Frontier · Feb 8, 2024 · 6693a12 · 6693a12
1 parent 107a5d8
commit 6693a12
Show file tree

Hide file tree

Showing 53 changed files with 717 additions and 831 deletions.
diff --git a/code/__DEFINES/dcs/signals/signals_object.dm b/code/__DEFINES/dcs/signals/signals_object.dm
@@ -138,8 +138,10 @@
 #define COMSIG_ITEM_PICKUP "item_pickup"
 ///from base of obj/item/on_outfit_equip(): (mob/equipper, visuals_only, slot)
 #define COMSIG_ITEM_EQUIPPED_AS_OUTFIT "item_equip_as_outfit"
-///from base of datum/storage/attempt_insert(): ()
+///from base of datum/storage/handle_enter(): (datum/storage/storage)
 #define COMSIG_ITEM_STORED "item_stored"
+///from base of datum/storage/handle_exit(): (datum/storage/storage)
+#define COMSIG_ITEM_UNSTORED "item_unstored"
 
 ///from base of obj/item/apply_fantasy_bonuses(): (bonus)
 #define COMSIG_ITEM_APPLY_FANTASY_BONUSES "item_apply_fantasy_bonuses"

diff --git a/code/__HELPERS/atoms.dm b/code/__HELPERS/atoms.dm
@@ -314,16 +314,6 @@ rough example of the "cone" made by the 3 dirs checked
 /proc/pass(...)
 	return
 
-///Returns a list of the parents of all storage components that contain the target item
-/proc/get_storage_locs(obj/item/target)
-	. = list()
-	if(!istype(target) || !(target.item_flags & IN_STORAGE))
-		return
-	var/datum/storage/storage_datum = target.loc.atom_storage
-	if(!storage_datum)
-		return
-	. += storage_datum.real_location?.resolve()
-
 /// Returns an x and y value require to reverse the transformations made to center an oversized icon
 /atom/proc/get_oversized_icon_offsets()
 	if (pixel_x == 0 && pixel_y == 0)