Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some warnings from compiler #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

burlito
Copy link

@burlito burlito commented Oct 23, 2013

No description provided.

@tristanheaven
Copy link
Collaborator

This would break _DEBUG builds.

@burlito
Copy link
Author

burlito commented Oct 23, 2013

I'm so sorry, I will fix this asap.

@burlito
Copy link
Author

burlito commented Oct 23, 2013

Ok, I belive it will work ok now.

Conflicts:
	smc/src/core/i18n.cpp
@datahead8888
Copy link

@tristanheaven or @Quintus - were we able to make use of this patch (or have we already put it to use)? I just was wondering.

@burlito - as I said in another reply - you are welcome to join our team at https://github.com/Secretchronicles/TSC. We are getting close to a new release of the game.

@Quintus
Copy link

Quintus commented Oct 3, 2014

The patch will not apply to the TSC sourcecode anymore, plus I don’t think simply casting to the unsigned value is the correct way of resolving the compiler warnings. The logic must be fixed, i.e. the variable in quesiton must be unsigned right from the beginning.

Vale,
Quintus

@burlito
Copy link
Author

burlito commented Oct 3, 2014

Hi,

Actually this wariabile was in first place signes, there was a some
reason why I changed that and recast in other place. however I'm not
sure why.

On 10/03/2014 03:40 AM, Marvin Gülker wrote:

The patch will not apply to the TSC sourcecode anymore, plus I don’t
think simply casting to the unsigned value is the correct way of
resolving the compiler warnings. The logic must be fixed, i.e. the
variable in quesiton must be unsigned right from the beginning.

Vale,
Quintus


Reply to this email directly or view it on GitHub
#5 (comment).

Kind regards,
b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants