!!! FEATURE: Neos 9.0 compatibility #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Jan 9, 2025
| <f:link.action action="purgeCache" format="json" arguments="{node: node}" class="neos-button clear-cache" title="Clear cache" data="{node-label: node.label}"><i class="fa fa-bolt"></i></f:link.action> | ||
| <div class="neos-hide" id="{node.identifier}"> | ||
| <button class="neos-button" data-toggle="modal" href="#{item.node.aggregateId}" title="Additional info" data-check-url="{f:uri.action(action: 'checkUrl', format: 'json', arguments: {url: url})}"><i class="fa fa-info-circle"></i></button> | ||
| <f:link.action action="purgeCache" format="json" arguments="{nodeAddress: item.nodeAddress}" class="neos-button clear-cache" title="Clear cache" data="{node-label: item.node.label}"><i class="fa fa-bolt"></i></f:link.action> |
There was a problem hiding this comment.
fyi this link generation here in combination with
NodeAddress::fromNode($node)->toJson()
in the varnishCacheController caused some discussion in https://neos-project.slack.com/archives/C04PYL8H3/p1736364381060509
Ill take care of figuring out what we want for the Neos 9 release - either having to use nodeAddress here manually or reallowing some autocasting magic in the back and passing a full node -> neos/neos-development-collection#5069
But for now, this code works and is used in other places as well. Its not wrong its just less magic and more explicit^^
dlubitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes this package Neos 9.0 compatible.
This needs to be tested carefully as main parts of the package have been rewritten based on new Neos ContentRepository.