Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add possibility to run application on custom domain name #172

Merged
merged 9 commits into from
Nov 26, 2024
Merged

feat: Add possibility to run application on custom domain name #172

merged 9 commits into from
Nov 26, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Nov 25, 2024 •
edited
Loading

Description

This pull request adds the possibility to define a custom domain for the FlowFuse application.
Additionally, it adds the possibility to define a path to a custom private CA certificate via DOCKER_DRIVER_PRIVATE_CA_PATH variable.

Related Issue(s)

Closes #173

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski marked this pull request as ready for review November 26, 2024 12:59
@ppawlowski ppawlowski requested a review from hardillb November 26, 2024 12:59
hardillb
hardillb approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK,

I'll try and spin up a copy later, but lets get it merged ahead of tomorrow.

@hardillb hardillb merged commit 251b10f into main Nov 26, 2024
2 checks passed
@hardillb hardillb deleted the feat-custom-app-domain branch November 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to run core app on different domain
2 participants
@ppawlowski @hardillb