-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New results model #1787
base: dev
Are you sure you want to change the base?
New results model #1787
Conversation
1. Use DynamicData SourceCache instead of our ResultCollection to reduce code complexity 2. Stop trigger Visibility when changes from empty to not empty or vise versa
This comment has been minimized.
This comment has been minimized.
@taooceros please list your tests @onesounds please check if ok:
|
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (6)LINQ To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/4083398394/attempts/1' To have the bot do this for you, reply quoting the following line: If the flagged items are 🤯 false positivesIf items relate to a ...
|
OK. That margin from 'MiddleSeparator' logic. that logic from 'BaseSeparatorStyle' in base.xaml A simple solution is to change the code as follows. However, in this case, the Separator is not displayed in the History view. (Ctrl+H) P.S. please mention the issue that I really need in Discord separately. There(github) are so many notifications that I can't check them all. 😓 |
Summary of the change
Effect:
Surprisingly the second change resolves #586, but will requires further test.
Though, it also introduce some style inconsistent. @onesounds will notice it easily.
More weirdly, if we switch to context menu and switch back, the style will become normal as current release.