Skip to content

Merge pull request #3059 from Flow-Launcher/dev #90

Merge pull request #3059 from Flow-Launcher/dev

Merge pull request #3059 from Flow-Launcher/dev #90

Triggered via push November 6, 2024 08:45
Status Success
Total duration 3m 44s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

42 warnings
build
The following actions use a deprecated Node.js version and will be forced to run on node20: notiz-dev/github-action-json-property@release. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build: Flow.Launcher.Infrastructure/Storage/BinaryStorage.cs#L68
The variable 'e' is declared but never used
build: Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs#L426
The variable 'e' is declared but never used
build: Plugins/Flow.Launcher.Plugin.Program/Settings.cs#L105
'Settings.ProgramSuffixes' is obsolete: 'Should use GetSuffixes() instead.'
build: Plugins/Flow.Launcher.Plugin.Program/Settings.cs#L107
'Settings.ProgramSuffixes' is obsolete: 'Should use GetSuffixes() instead.'
build: Plugins/Flow.Launcher.Plugin.Program/Settings.cs#L114
'Settings.ProgramSuffixes' is obsolete: 'Should use GetSuffixes() instead.'
build: Plugins/Flow.Launcher.Plugin.Program/Views/ProgramSetting.xaml.cs#L139
Avoid "async void" methods, because any exceptions not handled by the method will crash the process (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD100.md)
build: Plugins/Flow.Launcher.Plugin.Program/Main.cs#L54
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
build: Plugins/Flow.Launcher.Plugin.Program/Main.cs#L55
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
build: Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs#L232
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
build: Plugins/Flow.Launcher.Plugin.Program/Programs/Win32.cs#L252
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
build: Plugins/Flow.Launcher.Plugin.Program/Main.cs#L137
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
build: Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/ActionKeywordModel.cs#L32
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build: Plugins/Flow.Launcher.Plugin.Explorer/Helper/ShellContextMenu.cs#L1538
'AppDomain.GetCurrentThreadId()' is obsolete: 'AppDomain.GetCurrentThreadId has been deprecated because it does not provide a stable Id when managed threads are running on fibers (aka lightweight threads). To get a stable identifier for a managed thread, use the ManagedThreadId property on Thread instead.'
build: Plugins/Flow.Launcher.Plugin.Explorer/Helper/ShellContextMenu.cs#L344
Dereference of a possibly null reference.
build: Plugins/Flow.Launcher.Plugin.Explorer/Helper/SortOptionTranslationHelper.cs#L19
Dereference of a possibly null reference.
build: Plugins/Flow.Launcher.Plugin.Explorer/Search/EnvironmentVariables.cs#L50
Dereference of a possibly null reference.
build: Plugins/Flow.Launcher.Plugin.Explorer/Search/EnvironmentVariables.cs#L64
Dereference of a possibly null reference.
build: Plugins/Flow.Launcher.Plugin.Explorer/Views/ExplorerSettings.xaml.cs#L22
The field 'ExplorerSettings.actionKeywordsListView' is never used
build: Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/RelayCommand.cs#L20
The event 'RelayCommand.CanExecuteChanged' is never used
build: Plugins/Flow.Launcher.Plugin.Explorer/ContextMenu.cs#L408
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
build: Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/ActionKeywordModel.cs#L32
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build: Plugins/Flow.Launcher.Plugin.WebSearch/SettingsViewModel.cs#L7
Field 'SettingsViewModel._storage' is never assigned to, and will always have its default value null
build: Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml.cs#L33
Avoid "async void" methods, because any exceptions not handled by the method will crash the process (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD100.md)
build: Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml.cs#L128
Avoid "async void" methods, because any exceptions not handled by the method will crash the process (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD100.md)
build: Plugins/Flow.Launcher.Plugin.WebSearch/SettingsViewModel.cs#L7
Field 'SettingsViewModel._storage' is never assigned to, and will always have its default value null
build: Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml.cs#L33
Avoid "async void" methods, because any exceptions not handled by the method will crash the process (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD100.md)
build: Plugins/Flow.Launcher.Plugin.WebSearch/SearchSourceSetting.xaml.cs#L128
Avoid "async void" methods, because any exceptions not handled by the method will crash the process (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD100.md)
build: Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs#L318
Avoid method overloads that assume TaskScheduler.Current. Use an overload that accepts a TaskScheduler and specify TaskScheduler.Default (or any other) explicitly. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD105.md)
build: Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs#L35
'JsonRPCPlugin.JsonRPC' hides inherited member 'JsonRPCPluginBase.JsonRPC'. Use the new keyword if hiding was intended.
build: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs#L21
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
build: Flow.Launcher.Core/Updater.cs#L133
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
build: Flow.Launcher.Core/Plugin/ProcessStreamPluginV2.cs#L73
Possible null reference assignment.
build: Flow.Launcher.Core/Plugin/JsonRPCPluginV2.cs#L148
The variable 'e' is declared but never used
build: Flow.Launcher.Core/Plugin/JsonRPCPluginSettings.cs#L263
The switch expression does not handle all possible values of its input type (it is not exhaustive). For example, the pattern '_' is not covered.
build: Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptV2Environment.cs#L30
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
build: Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptEnvironment.cs#L30
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
build: Flow.Launcher.Core/ExternalPlugins/Environments/PythonEnvironment.cs#L35
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
build: Plugins/Flow.Launcher.Plugin.Shell/Main.cs#L402
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build: Plugins/Flow.Launcher.Plugin.Shell/Main.cs#L372
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)