Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader mock server #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Loader mock server #2

wants to merge 8 commits into from

Conversation

tushar89
Copy link
Contributor

@tushar89 tushar89 commented Sep 1, 2014

No description provided.

headers.put(headerName,request.getHeader(headerName));
}

ObjectMapper mapper = new ObjectMapper();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object mapper can be a static final at the top as class variable. Infact static does not matter since class is singleton.. Lets keep it just final...

@nitinka
Copy link
Contributor

nitinka commented Sep 5, 2014

Hi Himanshu,
Probably a late question. what is the need of creating your own mock server? Is need different than regular http mocking.
Isn't something like wiremock sufficient?

@tushar89
Copy link
Contributor Author

tushar89 commented Sep 5, 2014

Had a discussion with Balaji. There are some issues with wiremock wrt
scalability which is why we were instructed to do this.

Plus this service can be tweaked later to suit our needs specifically.

Adding Balaji for clarification.

Thanks,
Tushar

On Fri, Sep 5, 2014 at 3:06 PM, Nitin Kumar Agarwal <
[email protected]> wrote:

Hi Himanshu,
Probably a late question. what is the need of creating your own mock
server? Is need different than regular http mocking.
Isn't something like wiremock sufficient?


Reply to this email directly or view it on GitHub
#2 (comment).

@balajiarun
Copy link

Standalone wiremock is not scaling. So we are working on scalable mock server and to support more use cases
By mistake this is committed to loader repo, we will remove this mock server code from loader repo

Thanks
Balaji

@nitinka
Copy link
Contributor

nitinka commented Sep 11, 2014

Balaji,
Would it be possible to share the issues you are facing in scaling Wiremock.
What kind of load are you generating ?
Given the traction on Wiremock, I would be more inclined to enhance/fix Wiremock. Though using it within organisation would be your call anyways.

Regards
Nitinka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants