fix: POST /identities incorrectly applies segment overrides when using null or empty identifier, only in Core API
#5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing null or empty identifier, only in Core API
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
matthewelwell
approved these changes
Jan 20, 2025
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5018 +/- ##
=======================================
Coverage 97.39% 97.40%
=======================================
Files 1192 1192
Lines 41639 41654 +15
=======================================
+ Hits 40556 40571 +15
Misses 1083 1083 ☔ View full report in Codecov by Sentry. |
khvn26
deleted the
fix/incorrectly-applied-segment-overrides-transient-identities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Fixes #4976.
The problem boiled down to transient identities not having a primary key, which caused the query for fetching identity feature states to include segment overrides that don't belong there.
How did you test this code?
Added a unit test reproducing the exact problem reported.