Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set logger for skipping API usage #5003

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

zachaysan
Copy link
Contributor

Changes

Since none of the other logged messages around skipping processing API usage notifications my only theory right now is that the feature flag may have been hit so I'm adding in a logger around this area of the codebase.

How did you test this code?

Rely on existing coverage.

@zachaysan zachaysan requested a review from a team as a code owner January 15, 2025 16:33
@zachaysan zachaysan requested review from matthewelwell and removed request for a team January 15, 2025 16:33
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 15, 2025 4:33pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 15, 2025 4:33pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 15, 2025 4:33pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5003 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5003 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5003 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5003 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5003 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5003 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Uffizzi Preview deployment-59953 was deleted.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (64b2ed7) to head (fe19aac).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5003   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41633    41634    +1     
=======================================
+ Hits        40549    40550    +1     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 3c49ae0 into main Jan 17, 2025
35 checks passed
@matthewelwell matthewelwell deleted the fix/set_logger_for_skipping_api_usage branch January 17, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants