Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle fetch github stars errors #4952

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 3, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #4945

  • Don't show github star count when gh api fails
  • bypass error by adding a .catch handler

How did you test this code?

  1. Access flagsmith dashboard, on the top right, stars count should display
  2. Access flagsmith dashboard, on the top right, if gh api fails then stars count will not display

Success

Screenshot 2025-01-03 at 17 03 03

GitHub API Failure

Screenshot 2025-01-03 at 17 03 21

@tiagoapolo tiagoapolo requested a review from a team as a code owner January 3, 2025 20:42
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team January 3, 2025 20:42
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 0:38am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 0:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 0:38am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4952 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4952 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-4952 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4952 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4952 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4952 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4952 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Uffizzi Preview deployment-59512 was deleted.

@tiagoapolo tiagoapolo merged commit 580dcae into main Jan 6, 2025
31 checks passed
@tiagoapolo tiagoapolo deleted the fix/4945--handle-fetch-errors branch January 6, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants