Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Displays what entity is being edited in side modal #4927

Merged
merged 10 commits into from
Dec 18, 2024
Merged

feat: Displays what entity is being edited in side modal #4927

merged 10 commits into from
Dec 18, 2024
+22 −15

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Dec 17, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Displays bottom text to inform users which entity is being edited when they're editing roles, members, permissions.
  • Removes an unused import UserGroup

Ref: #4894

How did you test this code?

manually tested
Screenshot 2024-12-17 at 10 52 58

Screenshot 2024-12-17 at 11 08 29

@tiagoapolo tiagoapolo requested a review from a team as a code owner December 17, 2024 14:13
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team December 17, 2024 14:13
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 17, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:15pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:15pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4927 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4927 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4927 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4927 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4927 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4927 Finished ✅ Results ✅

@github-actions github-actions bot added the feature New feature or request label Dec 17, 2024
@tiagoapolo tiagoapolo self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Uffizzi Preview deployment-59178 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 17, 2024
@tiagoapolo tiagoapolo merged commit c1e0aea into main Dec 18, 2024
31 checks passed
@tiagoapolo tiagoapolo deleted the feat/edit-role branch December 18, 2024 14:08
@flagsmithdev flagsmithdev mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees

@tiagoapolo tiagoapolo

Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoapolo @kyle-ssg