feat(realtime): Add realtime support #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
force-pushed
the
feat/realtime
branch
from
6e7067e to
e35a6ef
Compare
gagantrivedi
requested review from
a team and
zachaysan
and removed request for
a team
zachaysan
approved these changes
Dec 12, 2024
realtime.go
Outdated
Comment on lines
40
to
43
| if err != nil { | ||
| c.log.Errorf("Error reading realtime stream: %v", err) | ||
| return | ||
| } |
There was a problem hiding this comment.
Are you sure you want to return here? Shouldn't we go back to listening to the stream on the hopes of the next data line includes the updated_at field?
There was a problem hiding this comment.
Yeah, I think you are right. I will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #144
NOTE: The failure of pre-commit.ci is not related to any code changes made in this pull request.