feat: Use RFC 3339, more lax datetime parsing #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
novakzaballa
and removed request for
a team
khvn26
changed the title
flagengine/utils/time.go
Outdated
|
|
||
| const iso8601 = "2006-01-02T15:04:05.999999" | ||
| "github.com/nav-inc/datetime" |
There was a problem hiding this comment.
Erk, this library does not look very well supported! It's not been touched in 3 years. I appreciate that it's probably not doing a lot, but have we searched for alternatives, or do we have evidence that this lib is widely used?
There was a problem hiding this comment.
Switched to github.com/itlightning/dateparse.
khvn26
force-pushed
the
feat/use-rfc3339
branch
3 times, most recently
from
b12e415 to
3d302d7
Compare
matthewelwell
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a necessary change to accommodate for the new server-side datetime serialisation — current strict ISO 8601 format couldn't process some of Pydantic's output.