Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate job, waiter deprecation, togglable init container #188

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Mar 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have bumped the version number in /charts/flagsmith/Chart.yaml in the section version or I'm merging to a
    release branch

Changes

This PR does the following:

  • Removes the wait-for-db init container as Flagsmith's entrypoint integrates this functionality.
  • Adds an ability to remove the migrate-db init container.
  • Adds an ability to deploy a migrate-db Kubernetes job, and customise it with extra containers and volumes.

This, along with #184, helps the chart users to add containers responsible for database connectivity, such as Google's cloud-sql-proxy.

How did you test this code?

This code now works as part of one of our enterprise on-premise deployments.

@khvn26 khvn26 merged commit 37486f8 into main Mar 6, 2024
2 checks passed
@khvn26 khvn26 deleted the feat/migrate-db-job branch March 6, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants