Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 111: option to remove use of waitforit image #137

Merged
merged 1 commit into from
Aug 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/flagsmith/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: flagsmith
description: Flagsmith
type: application
version: 0.21.0
version: 0.22.0
appVersion: 2.57.0
dependencies:
- name: postgresql
Expand Down
12 changes: 12 additions & 0 deletions charts/flagsmith/templates/deployment-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ spec:
initContainers:
{{- if eq .Values.databaseExternal.enabled false }}
matthewelwell marked this conversation as resolved.
Show resolved Hide resolved
- name: wait-for-db
{{- if .Values.api.dbWaiter.useExternalImage }}
image: {{ .Values.api.dbWaiter.image.repository }}:{{ .Values.api.dbWaiter.image.tag }}
imagePullPolicy: {{ .Values.api.dbWaiter.image.imagePullPolicy }}
command:
Expand All @@ -73,6 +74,17 @@ spec:
{{- end }}
- --port=5432
- --timeout={{ .Values.api.dbWaiter.timeoutSeconds }}
{{- else }}
image: {{ .Values.api.image.repository }}:{{ .Values.api.image.tag | default (printf "%s" .Chart.AppVersion) }}
imagePullPolicy: {{ .Values.api.image.imagePullPolicy }}
command:
- python
- manage.py
- waitfordb
- --waitfor
- {{ .Values.api.dbWaiter.timeoutSeconds | quote }}
env: {{ include (print $.Template.BasePath "/_api_environment.yaml") . | nindent 8 }}
{{- end }}
{{- end }}
- name: migrate-db
image: {{ .Values.api.image.repository }}:{{ .Values.api.image.tag | default (printf "%s" .Chart.AppVersion) }}
Expand Down
1 change: 1 addition & 0 deletions charts/flagsmith/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ api:
successThreshold: 1
timeoutSeconds: 2
dbWaiter:
useExternalImage: true
image:
repository: willwill/wait-for-it
tag: latest
Expand Down
Loading