Added switch and value flag suggestions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FixedDev
added
enhancement
yusshu
approved these changes
Aug 27, 2021
Examples/src/main/java/me/fixeddev/commandflow/examples/basic/SwitchArguments.java
Outdated
Show resolved
Hide resolved
Universal/src/main/java/me/fixeddev/commandflow/part/defaults/SequentialCommandPart.java
Show resolved
Hide resolved
OcZi
reviewed
Sep 11, 2021
Examples/src/main/java/me/fixeddev/commandflow/examples/basic/SwitchArguments.java
Outdated
Show resolved
Hide resolved
If we use "-g" directly then the only suggestion available is nothing, so only use "-"
OcZi
approved these changes
Sep 11, 2021
Neerixx
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by #15, we added tab completion for switch and value flags only when the next argument starts with a "-".
To allow this we needed custom treatment on the SequentialCommandParts for the ValueFlagPart and SwitchPart.
More testing is needed before merging this into the main branch, since only basic testing was done before creating the pull request with the changes