Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

references: add offset to pull #25

Closed
wants to merge 1 commit into from
Closed

Conversation

Fishrock123
Copy link
Owner

Refs: #23

@Raynos
Copy link
Collaborator

Raynos commented Aug 6, 2019

If you add an offset to pull() it makes sense to also add an offset to next()

@Fishrock123
Copy link
Owner Author

@Raynos You mean to note where that particular read was done from?

@Raynos
Copy link
Collaborator

Raynos commented Aug 6, 2019

Correct, to note at which offset the n bytes where read into the buffer.

But this raises a good question, what does offset on pull() mean ? the offset to read into in the buffer or the offset to read from in whatever the source is ( like an offset in a file on disk ).

@Fishrock123
Copy link
Owner Author

It was supposed to be source read location. I am still not really sure this fits well into the stream abstraction...

@Raynos
Copy link
Collaborator

Raynos commented Mar 4, 2024

Closing out due to lack of activity.

@Raynos Raynos closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants