2534 Improve performance of Date handling #2541
Conversation
| [NonSerialized] // To prevent binary serialization from serializing this field | ||
| private P.Date? _parsedValue = null; | ||
|
|
||
| private static readonly P.Date INVALID_VALUE = P.Date.Today(); |
There was a problem hiding this comment.
This would resolve to the current value on initialization of the app, hence long running services would have the boot time in this value, shouldn't it be a function so it is evaluated each time it is called?
There was a problem hiding this comment.
No. hasInvalidParsedValue() uses ReferenceEquals() to compare the cached time to INVALID_VALUE, so the actual value does not matter: it could have been mine or your birthdate as well. It's used here as a sentinel value to just indicate the value is invalid (as opposed to not cached (null)). It avoids keeping a separate bool hasInvalidValue that I need to keep synchronized.
There was a problem hiding this comment.
In case someone is looking at the data, would it be better to use something like DateTime.MinValue to make it obvious?
Replicated changes from DateTime to Date.
Resolves #2534.