-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the stored subsystem name via the subsystem handle #98
Conversation
Would you mind adding a test for it as well? |
Ideally, where you test two levels of nested subsystems to make sure the name gets properly constructed |
Would mind extending the test to check the nested-ness of nested subsystems? :) sorry to be pedantic :D |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 97.30% 97.32% +0.01%
==========================================
Files 15 15
Lines 669 672 +3
Branches 669 672 +3
==========================================
+ Hits 651 654 +3
Misses 3 3
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Not minding at all, no problem: I added an integration test (is the I also added a small note in the original
I'm not quite sure what you mean, sorry: You want to test that nested subsystems are actually nested? And no worries about being pedantic, let's do it right. Edit: Typo |
That's exactly what I meant, that's perfect :) |
Closes #97