Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the stored subsystem name via the subsystem handle #98

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

girstenbrei
Copy link
Contributor

Closes #97

@Finomnis
Copy link
Owner

Would you mind adding a test for it as well?

@Finomnis
Copy link
Owner

Finomnis commented Jan 10, 2025

Ideally, where you test two levels of nested subsystems to make sure the name gets properly constructed

@Finomnis
Copy link
Owner

Would mind extending the test to check the nested-ness of nested subsystems? :) sorry to be pedantic :D

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (11c85eb) to head (8f3eff5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   97.30%   97.32%   +0.01%     
==========================================
  Files          15       15              
  Lines         669      672       +3     
  Branches      669      672       +3     
==========================================
+ Hits          651      654       +3     
  Misses          3        3              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@girstenbrei
Copy link
Contributor Author

girstenbrei commented Jan 10, 2025

Not minding at all, no problem:

I added an integration test (is the integration_test.rs the preferred location? It looked like a good candidate) with 2 nested subsystems and testing their respective generated names and that the name nest correctly.

I also added a small note in the original name() fn regarding how names are constructed. I think this should be documented somewhere, I just don't know if this is the correct location. Maybe the SubsystemBuilder::new would be better, what do you think?

Would mind extending the test to check the nested-ness of nested subsystems? :) sorry to be pedantic :D

I'm not quite sure what you mean, sorry: You want to test that nested subsystems are actually nested? And no worries about being pedantic, let's do it right.

Edit: Typo

@Finomnis
Copy link
Owner

That's exactly what I meant, that's perfect :)

@Finomnis Finomnis merged commit d3d8888 into Finomnis:main Jan 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access name of subsystem
2 participants