Full rewrite #64
Merged
Full rewrite #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full rewrite of this crate
The main problem was that the API followed the implementation and not the other way round. Some API improvements weren't possible because they weren't implementable.
With the new implementation, several API decisions that bothered me were finally improved.
Breaking Changes
Toplevel::nested(which was a rather ugly hack), replace with configurableErrorActions.NestedSubsystem::initiate_shutdown()andNestedSubsystem::join().SubsystemHandle::wait_for_children().Toplevel::start. Instead, add a single subsystem toToplevel::new, which can then spawn all further subsystems.SubsystemHandle::start; it now takes aSubsystemBuilderobject that provides further subsystem configuration options.1.63.0.The rest of the API is almost identical and migration should be mostly straight forward.