Allow commands with no parameters to compile (#20)

Use `Array.Empty<T>()` instead of `new[] { }` or `new IParameter[] { }` when no parameters are specified
FiniteReality · Jun 12, 2021 · 02f7615 · 02f7615
1 parent 773bb4a
commit 02f7615
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 8 deletions.
diff --git a/samples/Console/TestCommands/HelloWorldCommand.cs b/samples/Console/TestCommands/HelloWorldCommand.cs
@@ -42,5 +42,13 @@ public ValueTask<ICommandResult> HelloWorldCommand(
 
             return new ValueTask<ICommandResult>(new NoContentCommandResult());
         }
+
+        [Command("code")]
+        public ValueTask<ICommandResult> HelloCodeCommand()
+        {
+            _logger.LogInformation("Hello code from HelloModule!");
+
+            return new ValueTask<ICommandResult>(new NoContentCommandResult());
+        }
     }
 }
diff --git a/...s/SourceGenerators/Models/AttributedModel/AttributedModelSourceGenerator.CommandSource.cs b/...s/SourceGenerators/Models/AttributedModel/AttributedModelSourceGenerator.CommandSource.cs
@@ -80,6 +80,13 @@ var parameterNamespaces
                     .Select(
                         x => $"new CommandFactory__{@class.Name}__{method.Name}__{x.Name}()"));
 
+            var parameterArray = parameterTypes == string.Empty
+                ? "Array.Empty<IParameter>()"
+                : $@"new IParameter[]
+            {{
+                {parameterTypes}
+            }}";
+
             var parameterAccessors = string.Join(", ",
                 method.Parameters
                     .Select(
@@ -97,6 +104,13 @@ var parameterNamespaces
                 method.Parameters
                     .Select(x => $"typeof({x.ToDisplayString()})"));
 
+            var reflectionArray = reflectionTypes == string.Empty
+                ? "types: Array.Empty<Type>()"
+                : $@"types: new[]
+                    {{
+                        {reflectionTypes}
+                    }}";
+
             return
 $@"{namespaces}
 
@@ -118,21 +132,15 @@ private static readonly MethodInfo Method
                     bindingAttr: {GetBindingFlags(method)},
                     binder: default,
                     callConvention: {GetCallConv(method)},
-                    types: new[]
-                    {{
-                        {reflectionTypes}
-                    }},
+                    {reflectionArray},
                     modifiers: null)!;
 
         private IReadOnlyDictionary<object, object?>? _data;
 
         public CommandString Name {{ get; }} = {commandPath};
 
         public IReadOnlyList<IParameter> Parameters {{ get; }}
-            = new IParameter[]
-            {{
-                {parameterTypes}
-            }};
+            = {parameterArray};
 
         public IReadOnlyDictionary<object, object?> Data
         {{