Skip to content

Commit

Permalink
Fix build issue on Android
Browse files Browse the repository at this point in the history
Fix npm commands
  • Loading branch information
sc85 committed Apr 28, 2020
1 parent a8d9947 commit 587ead1
Show file tree
Hide file tree
Showing 9 changed files with 4,960 additions and 12,626 deletions.
6 changes: 3 additions & 3 deletions demo/app/main-page.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Page
xmlns="http://schemas.nativescript.org/tns.xsd"
xmlns:pdf="nativescript-pdf-view"
loaded="pageLoaded">
xmlns="http://schemas.nativescript.org/tns.xsd"
xmlns:pdf="@finanzritter/nativescript-pdf-view"
loaded="pageLoaded">
<FlexboxLayout flexDirection="column">
<Button height="70" text="Show Another!" tap="{{ changePDF }}" />
<pdf:PDFView flexGrow="1" src="{{ pdfUrl }}" load="{{ onLoad }}" enableAnnotationRendering="{{ enableAnnotationRendering }}" />
Expand Down
2 changes: 1 addition & 1 deletion demo/app/main-view-model.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Observable } from 'data/observable';
import { PDFView } from 'nativescript-pdf-view';
import { PDFView } from '@finanzritter/nativescript-pdf-view';

export class MainViewModel extends Observable {
public pdfUrls = [
Expand Down
2 changes: 1 addition & 1 deletion demo/app/tests/tests.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var PDFView = require("nativescript-pdf-view").PDFView;
var PDFView = require("@finanzritter/nativescript-pdf-view").PDFView;
var pdfView = new PDFView();

describe("PDFView", function() {
Expand Down
17,529 changes: 4,932 additions & 12,597 deletions demo/package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}
},
"dependencies": {
"nativescript-pdf-view": "file:..",
"@finanzritter/nativescript-pdf-view": "file:../src",
"nativescript-theme-core": "~1.0.2",
"nativescript-unit-test-runner": "0.7.0",
"tns-core-modules": "6.0.1"
Expand Down
24 changes: 11 additions & 13 deletions src/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 10 additions & 9 deletions src/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@finanzritter/nativescript-pdf-view",
"version": "2.1.2",
"version": "2.1.3",
"description": "A basic PDF viewer plugin for NativeScript, to display PDF documents on iOS and Android.",
"main": "pdf-view",
"typings": "index.d.ts",
Expand All @@ -12,16 +12,17 @@
},
"scripts": {
"build": "tsc",
"demo.ios": "npm run preparedemo && cd demo && tns run ios --emulator",
"demo.ios.device": "npm run preparedemo && cd demo && tns run ios",
"demo.android": "npm run preparedemo && cd demo && tns run android --emulator",
"demo.ios": "npm run preparedemo && cd ../demo && tns run ios --emulator",
"demo.ios.device": "npm run preparedemo && cd ../demo && tns run ios",
"demo.android": "npm run preparedemo && cd ../demo && tns run android --emulator",
"demo.android.device": "npm run preparedemo && cd ../demo && tns run android",
"lint": "tslint --project tsconfig.json -t stylish",
"test.ios": "cd demo && tns test ios --emulator",
"test.ios.device": "cd demo && tns test ios",
"test.android": "cd demo && tns test android",
"preparedemo": "npm run build && cd demo && tns plugin remove nativescript-pdf-view && tns plugin add .. && tns install",
"test.ios": "cd ../demo && tns test ios --emulator",
"test.ios.device": "cd ../demo && tns test ios",
"test.android": "cd ../demo && tns test android",
"preparedemo": "npm run build && cd ../demo && tns plugin remove @finanzritter/nativescript-pdf-view && tns plugin add ../src && tns install",
"prepare": "npm run build",
"setup": "npm ci && cd demo && npm ci && cd .. && npm run build && cd demo && tns plugin add .. && cd .."
"setup": "npm ci && cd ../demo && npm ci && cd ../src && npm run build && cd ../demo && tns plugin add ../src && cd ../src"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion src/pdf-view.common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ export abstract class PDFViewCommon extends View {
}

export const enableAnnotationRenderingProperty = new Property<PDFViewCommon, boolean>({
name: 'enableAnnotationRendering',
defaultValue: false,
name: 'enableAnnotationRendering',
});
enableAnnotationRenderingProperty.register(PDFViewCommon);

Expand Down
File renamed without changes.

0 comments on commit 587ead1

Please sign in to comment.