feat: use typography use case tokens in o message #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frshwtr
commented
Jan 16, 2025
| font-family: oPrivateFoundationGet('o3-typography-use-case-body-highlight-font-family'); | ||
| font-size: oPrivateFoundationGet('o3-typography-use-case-body-highlight-font-size'); | ||
| font-weight: oPrivateFoundationGet('o3-typography-use-case-body-highlight-font-weight'); | ||
| line-height: oPrivateFoundationGet('o3-typography-use-case-body-highlight-line-height'); | ||
| } | ||
|
|
||
| .o-message__content-main a, | ||
| .o-message__content-additional a { | ||
| @include oPrivateTypographyLink(); |
There was a problem hiding this comment.
oPrivateTypographyLink provides text decoration and colour for states for links. Thus why it is still here.
frshwtr
force-pushed
the
2025-release-use-typography-use-case-tokens-in-o-message
branch
from
3856396 to
f0b2fb5
Compare
|
Slack conversation here on what to do with the small button: https://financialtimes.slack.com/archives/G03ACR1MJ/p1737037912781139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Uses the new typography use case tokens in o-message components
Issue ticket number and link
Link to Figma designs
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md