Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monorepo plugin #630

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Monorepo plugin #630

wants to merge 25 commits into from

Conversation

apaleslimghost
Copy link
Member

@apaleslimghost apaleslimghost commented Apr 24, 2024 •
edited
Loading

pretty barebones right now, but it works!

  • just exports a task. if you want to run commands in your workspace packages, run that task at the toplevel, and it will run the same command in the workspace

    example

    .toolkitrc.yml

    commands:
  test:local: WorkspaceCommand

    packages/something/.toolkitrc.yml

    commands:
  test:local: Cypress # only needed in this package

    npx dotcom-tool-kit test:local in the root runs test:local in packages/something, which runs Cypress

  • refactors some stuff in the core to expose some internals needed for the monorepo task → make tool kit config loading agnostic of CWD #709

  • rudimentary error handling and logging, i would like to go through this with a fine tooth comb when i get chance

opened as a draft as i want to discuss whether it's worth merging in its current state or if it needs fleshing out a bit more

still to do:

  • proper error handling and logging
  • tests!
  • try migrating cp-content-pipeline to it 😬
  • filtering which workspace packages to run command on?
    • glob vs regex?
  • documentation (plugin + high level monorepo workflow overview)

@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch from a617d77 to 456ce34 Compare May 9, 2024 08:58
ivomurrell
ivomurrell reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@ivomurrell ivomurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm very happy that this is so simple! though the proof is in the cp-content-pipeline pudding...

plugins/monorepo/package.json Show resolved Hide resolved
@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch 2 times, most recently from b451dfb to 32c9c65 Compare July 25, 2024 11:30
@apaleslimghost apaleslimghost mentioned this pull request Jul 25, 2024
Merged
@apaleslimghost apaleslimghost changed the base branch from next to create-plugin-fixes July 25, 2024 13:41
Base automatically changed from create-plugin-fixes to next July 25, 2024 13:42
@apaleslimghost apaleslimghost mentioned this pull request Jul 25, 2024
Merged
@apaleslimghost apaleslimghost changed the base branch from next to task-context July 25, 2024 13:47
@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch 2 times, most recently from 0e0ae70 to 5a89031 Compare July 25, 2024 16:02
@apaleslimghost apaleslimghost mentioned this pull request Jul 25, 2024
Merged
@apaleslimghost apaleslimghost changed the base branch from task-context to split-config-loading July 25, 2024 16:03
@apaleslimghost apaleslimghost marked this pull request as ready for review October 1, 2024 13:13
@apaleslimghost apaleslimghost requested a review from a team as a code owner October 1, 2024 13:13
Base automatically changed from split-config-loading to main October 1, 2024 14:55
@apaleslimghost apaleslimghost mentioned this pull request Nov 8, 2024
Merged
@apaleslimghost apaleslimghost changed the base branch from main to roots-manuva November 8, 2024 10:21
@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch 2 times, most recently from b2fc7bf to 4bf06ab Compare December 2, 2024 11:09
@apaleslimghost
feat: load workspace package tool kit configs
45ca3d6
@apaleslimghost
feat: run workspace commands in parallel
84f92af
@apaleslimghost
refactor: use map instead of a for loop for runPackageCommand calls
2f0d2d6
@apaleslimghost
feat: allow overriding which command to run in the workspace via a ta…
91e39ca 
…sk option
@apaleslimghost
build: don't throw in generate-docs when no readme
38abba6
@apaleslimghost
build: inherit volta config from root
8391912
@apaleslimghost
backstage: update monorepo plugin dependency versions
03be336
@apaleslimghost
docs(monorepo): add readme
881c462
@apaleslimghost
docs(monorepo): add high-level workflow explanation
08e3c19
@apaleslimghost
docs(monorepo): document plugin vs npm run --workspaces considerations
9bb7be2
@apaleslimghost
build: compile the monorepo plugin
8a5279c
@apaleslimghost
feat(monorepo): add a packageFilter option
a201fb8
@apaleslimghost
docs: automatically regenerate schema docs
b80520a
@apaleslimghost
feat: use an AggregateError for workspace package command errors
463f651
@apaleslimghost
feat: pass cwd into init
7b9311c
@apaleslimghost
fix: run init before printing help
78578f6
@apaleslimghost
refactor: load workspace configs at init not task run
7aa50b1
@apaleslimghost
feat: only attempt to run workspace command in packages that have it,…
f3b3b64 
… and log which packages

(instead of logging a bunch of "no task configured for test:local: skipping assignment...")
@apaleslimghost
feat: print workspace package name in task run errors
57252f1
@apaleslimghost
test: add basic test for LoadWorkspaceConfigs
47722ad
@apaleslimghost
test: add tests for LoadWorkspaceConfigs failure behaviour
1f163c5
@apaleslimghost
fix(typescript): resolve tsc path from cwd
6447660
@apaleslimghost
fix: prevent running nodemon in non-root directories
782400e
@apaleslimghost apaleslimghost changed the base branch from main to node-watch December 2, 2024 16:56
Base automatically changed from node-watch to main December 2, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivomurrell ivomurrell ivomurrell left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaleslimghost @ivomurrell