Merge pull request #723 from Financial-Times/fix-native-fetch

Fix native fetch
Financial-Times · Dec 9, 2024 · 8f9ad7e · 8f9ad7e
2 parents c84315e + edf6443
commit 8f9ad7e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/cli/src/fetch.ts b/core/cli/src/fetch.ts
@@ -6,8 +6,5 @@ export const shouldDisableNativeFetch = (options: RootOptions): boolean => {
   // disable Node 18's native fetch if the Node runtime supports it (older
   // runtimes don't support the flag, implying they also don't use native
   // fetch) and the user hasn't opted out of the behaviour
-  return (
-    options.allowNativeFetch &&
-    process.allowedNodeEnvironmentFlags.has('--no-experimental-fetch')
-  )
+  return !options.allowNativeFetch && process.allowedNodeEnvironmentFlags.has('--no-experimental-fetch')
 }
diff --git a/core/cli/src/tasks.ts b/core/cli/src/tasks.ts
@@ -65,7 +65,10 @@ export async function runTasksFromConfig(
   await runInit(logger, config)
   await checkInstall(logger, config)
 
-  if (shouldDisableNativeFetch(config.pluginOptions['app root'].options)) {
+  if (
+    shouldDisableNativeFetch(config.pluginOptions['app root'].options) &&
+    !process.execArgv.includes('--no-experimental-fetch')
+  ) {
     process.execArgv.push('--no-experimental-fetch')
   }