chore: fix logic error

FinTechIntro · Sep 7, 2024 · 41eed3c · 41eed3c
1 parent 3198565
commit 41eed3c
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/hw/lib/openzeppelin-contracts b/hw/lib/openzeppelin-contracts
diff --git a/hw/src/Loan/BadCaller.sol b/hw/src/Loan/BadCaller.sol
@@ -71,8 +71,8 @@ contract BadCaller {
         return loanToken.balanceOf(address(this));
     }
 
-    /// @notice Provides a flash loan with zero fees for new users
-    /// @dev Charges a fee for users who have previously used the platform, checks for repayment
+    /// @notice Provides a flash loan with zero fees for old users
+    /// @dev Charges a fee for new users who have never used the platform, checks for repayment
     /// @param target The address to which the funds will be sent and that will execute the transaction
     /// @param amount The amount of the loan
     /// @param data The call data to be sent to the `target` address

diff --git a/hw/src/NFinTech/NFinTech.sol b/hw/src/NFinTech/NFinTech.sol
@@ -17,6 +17,12 @@ interface IERC721 {
     event ApprovalForAll(address indexed owner, address indexed operator, bool approved);
 }
 
+interface IERC721TokenReceiver {
+    function onERC721Received(address operator, address from, uint256 tokenId, bytes calldata data)
+        external
+        returns (bytes4);
+}
+
 
 contract NFinTech is IERC721 {
     string private _name;

diff --git a/hw/test/Delegation/BankBase.t.sol b/hw/test/Delegation/BankBase.t.sol
@@ -28,8 +28,7 @@ contract BankBaseTest is Test {
         victim = makeAddr("victim");
         deal(victim, 100 ether);
 
-        user = makeAddr("user");
-        deal(user, 1 ether);
+        deal(address(this), 1 ether);
 
         // Contract
         bank = new Bank();

diff --git a/hw/test/NFinTech/NFinTech.t.sol b/hw/test/NFinTech/NFinTech.t.sol
@@ -2,7 +2,7 @@
 pragma solidity ^0.8.0;
 
 import {Test, console2} from "forge-std/Test.sol";
-import "../../src/NFinTech/NFinTech.sol";
+import {NFinTech, IERC721TokenReceiver, IERC721} from "../../src/NFinTech/NFinTech.sol";
 
 /// @title NFinTech Test
 /// @author Louis Tsai