Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml: pattern needs to be '**' #594

Closed
wants to merge 1 commit into from

Conversation

@0x2b3bfa0
Copy link
Contributor

@pheiduck, what was wrong with the previous age-binaries-* pattern; didn't it work correctly?

@pheiduck
Copy link
Author

On the project sbctl there were not all binaries uploaded to releases maybe it does not effect this project?

https://github.com/Foxboron/sbctl/actions/runs/11410824044/job/31753919739

@0x2b3bfa0
Copy link
Contributor

0x2b3bfa0 commented Nov 29, 2024

The issue you mention (Foxboron/sbctl@53e074d → .github/workflows/build.yml:60) happened because sbctl's workflow tries to reference the matrix context in a job where it's not set. If they used a wildcard like we do in age's it wouldn't have failed:

-          name: sbctl-binaries-${{ matrix.GOOS }}-${{ matrix.GOARCH }}
+          name: sbctl-binaries-*

Copy link
Contributor

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the age workflow isn't broken, and this change is functionally superfluous. Nevertheless, thanks for the pull request.

I'd say if it ain't broke, don't fix it, although there's nothing inherently wrong with this change; let's wait for official reviews.

@pheiduck pheiduck closed this by deleting the head repository Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants