Skip to content

Commit

Permalink
Migrate to shared-actions v2
Browse files Browse the repository at this point in the history
> [!IMPORTANT]
> **Please thoroughly review this PR before approving and merging**
> This migration is complicated and may require some manual changes. Below we will call out breaking changes and other important notes.

This PR moves all workflows to the new shared-actions v2. Please check out the following docs for more information on this migration:
- [Migration Guide](https://docs.devops.figure.com/shared-actions/v2-migration-guide)
- [Migration Changes](https://docs.devops.figure.com/shared-actions/v2-migration-changes)

Please reach out to [#github-actions-help](https://figure-group.slack.com/archives/C044W9BRAVD) with any and all questions, someone from devops or core tech will be able to help.

---

### Notes
- Once you've merged in this PR and are running `v2` actions it is worth watching your workflows for warnings about inputs that are no longer used. We are able to handle a lot of replacements automatically, but we err on the side of caution to avoid breaking other github actions that we don't own. These warnings won't ever break your builds, but it is good practice to keep them clean.
- Some other common upgrades are also done in this PR, like updating other `actions/` to their latest versions.

🤖🪄 This PR was automatically created by a magic script.
  • Loading branch information
ahatzz11 committed Sep 10, 2024
1 parent 6169cf6 commit d2a588b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ jobs:
name: Build OSX
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install osx tools
run: |
brew tap mitchellh/gon
brew install mitchellh/gon/gon
- name: Setup go
uses: actions/setup-go@v4.0.0
uses: actions/setup-go@v5
with:
go-version: ${{ needs.build_init.outputs.go_version }}
- name: Import Code-Signing Certificates
Expand All @@ -46,7 +46,7 @@ jobs:
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
run: |
gon -log-level=info -log-json ./gon.json
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: osx-zip
path: build/*.zip
Expand All @@ -58,15 +58,15 @@ jobs:
name: Build Linux
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup go
uses: actions/setup-go@v4.0.0
uses: actions/setup-go@v5
with:
go-version: ${{ needs.build_init.outputs.go_version }}
- name: Build linux binary
run: |
make release linux-release
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: linux-zip
path: build/*.zip
Expand All @@ -80,7 +80,7 @@ jobs:
name: Create Release
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Create release ${{ needs.build_init.outputs.version }}
uses: actions/create-release@v1
id: create_release
Expand All @@ -104,21 +104,21 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
-
name: Setup go
uses: actions/setup-go@v4.0.0
uses: actions/setup-go@v5
with:
go-version: ${{ needs.build_init.outputs.go_version }}
-
name: Download linux zip artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: linux-zip
path: build/
-
name: Download osx zip artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: osx-zip
path: build/
Expand All @@ -141,4 +141,4 @@ jobs:
upload_url: ${{ needs.create_release.outputs.release_url }}
asset_path: ./build/jwt-wallet-linux-amd64-${{ needs.build_init.outputs.version }}.zip
asset_name: jwt-wallet-linux-amd64-${{ needs.build_init.outputs.version }}.zip
asset_content_type: application/octet-stream
asset_content_type: application/octet-stream
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Checkout
uses: actions/checkout@master
- name: Setup go
uses: actions/setup-go@v4
uses: actions/setup-go@v5
with:
go-version: 1.18
- name: Go mod vendor
Expand Down

0 comments on commit d2a588b

Please sign in to comment.