Skip to content

Commit

Permalink
Migrate to shared-actions v2
Browse files Browse the repository at this point in the history
> [!IMPORTANT]
> **Please thoroughly review this PR before approving and merging**
> This migration is complicated and may require some manual changes. Below we will call out breaking changes and other important notes.

This PR moves all workflows to the new shared-actions v2. Please check out the following docs for more information on this migration:
- [Migration Guide](https://docs.devops.figure.com/shared-actions/v2-migration-guide)
- [Migration Changes](https://docs.devops.figure.com/shared-actions/v2-migration-changes)

Please reach out to [#github-actions-help](https://figure-group.slack.com/archives/C044W9BRAVD) with any and all questions, someone from devops or core tech will be able to help.

---

### Notes
- Once you've merged in this PR and are running `v2` actions it is worth watching your workflows for warnings about inputs that are no longer used. We are able to handle a lot of replacements automatically, but we err on the side of caution to avoid breaking other github actions that we don't own. These warnings won't ever break your builds, but it is good practice to keep them clean.
- Some other common upgrades are also done in this PR, like updating other `actions/` to their latest versions.

🤖🪄 This PR was automatically created by a magic script.
  • Loading branch information
ahatzz11 committed Sep 10, 2024
1 parent 6806084 commit 8d1b1da
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
fetch-depth: 0
- name: Setup go
uses: actions/setup-go@v4
uses: actions/setup-go@v5
with:
go-version: 1.18
- name: Go mod vendor
Expand Down Expand Up @@ -47,17 +47,17 @@ jobs:
echo ::set-output name=created::$(date -u +'%Y-%m-%dT%H:%M:%SZ')
- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- name: Available platforms
run: echo ${{ steps.buildx.outputs.platforms }}
- name: Login to DockerHub
uses: docker/login-action@v2
uses: docker/login-action@v3
if: ${{ github.event_name != 'pull_request' }}
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Publish to Docker Hub
uses: docker/build-push-action@v4
uses: docker/build-push-action@v6
with:
context: .
target: run
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 6
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: technote-space/[email protected]
with:
PATTERNS: |
Expand All @@ -24,5 +24,5 @@ jobs:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.52.2
args: --timeout 10m
github-token: ${{ secrets.github_token }}
github-token: ${{ secrets.
if: env.GIT_DIFF
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Checkout
uses: actions/checkout@master
- name: Setup go
uses: actions/setup-go@v4
uses: actions/setup-go@v5
with:
go-version: 1.18
- name: Go mod vendor
Expand Down

0 comments on commit 8d1b1da

Please sign in to comment.