Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: CLIN-3267 Code review suggestion #408

Open
wants to merge 2 commits into
base: feat/CLIN-3267-align-nextflow-operator-with-cqdg-k8s-operators-structure
Choose a base branch
from
Open

♻️ refactor: CLIN-3267 Code review suggestion #408

wants to merge 2 commits into from

Commits on Oct 10, 2024

  1. feat: CLIN-3267 align nextflow operator with cqdg k8s operators struc… 

    …ture

This code works locally with minikube for test_nextflow_operator. It is not tested on etl.py.

It reuse a configuration mechanism similar as in cqdg
Key modifications in comparison to cqdg:
- service_account_name specified in BaseConfig instead KubeConfig
- shallow copy in build_operator and partial methods in BaseConfig
- BaseConfig.args renamed to BaseConfig.append_args
    @LysianeBouchard
    LysianeBouchard committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    dda54a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. ♻️ refactor: CLIN-3267 Code review suggestion

    @laurabegin
    laurabegin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c4492b9 View commit details
    Browse the repository at this point in the history