[Fix] Wrong Arabic Translation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Ghamza-Jd,
Also, I'm pretty sure we have to adjust the Settings.bundle piece as well: |
|
@FelixHerrmann Nice! I believe the apple one is better as it keeps things consistent whilst the translation is correct. Will update the patch, thanks! |
FelixHerrmann
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this nice tool! I found the Arabic localization was mistranslated
The current one "مخزن" means storage or warehouse.
The proposed change "الشكر والتقدير" means acknowledgments or being thankful and appreciation.
Note
Acknowledgment in English has multiple meanings, in this context it could be one of two, either "Recognition" or "Appreciation" and I believe it's the latter.