This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
WIP: Import options - better gopilosa.StatusChan support #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just putting this PR here so you can see what I changed in the PDK in order to get the StatusChan to work. It builds on top of #78. There are still some issues. It assumes that a frame contains only one of:
Even with this limitation, and protection in the PDK, there is a still a potential panic situation (closing of a closed channel) in go-pilosa that I marked with a TODO in a PR to that repo.
The general idea here is that
StatusChan
is frame-specific, so I made it part of theFrameSpec
instead of provided as a functional option for the entire index inSetupPilosa()
.I don't think it's necessary to merge this PR into master, but we'll need to consider all of this as we refactor Pilosa. I think the
Frame
toField
logic will help because that will effectively enforce the limitations listed above.