Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Implements Client-Side RowKey translation on import #140

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yuce
Copy link
Contributor

@yuce yuce commented Nov 27, 2018

  • Requires Pilosa compiled from: Added /internal/translate/keys endpoint featurebase#1751
  • Currently works for RowKeyColumnID type data
  • It works on roaring import.
  • It works on CSV import. Temporarily disabled that though, since it requires ignoreKeyCheck flag; unconditionally enabling it breaks some tests, so need to look into that.
  • Although not enabled currently, it should be easy to implement it for RowIDColumnKey and RowKeyColumnKey type data.
  • Value fields are not supported yet, but should be trivial to implement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 98.621% when pulling 7e16d5d on yuce:row-keys-to-id-mapper into 4f922ff on pilosa:master.

@coveralls
Copy link

coveralls commented Nov 27, 2018

Coverage Status

Coverage decreased (-1.2%) to 98.077% when pulling 55649f6 on yuce:row-keys-to-id-mapper into 3aaa205 on pilosa:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants