Fix mob attacks using setHealth #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix brute zombie attack * Fix brute wither skeleton attack * Fix brute skeleton attack * Fix brute pig zombie attack * Fix ember blaze attack * Fix inferno blaze attack * Fix fighter ghast attack * Fix unholy ghast attack * Fix vampire pig zombie attack
|
This commit would fix the crash related to #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several mobs using
setHealthto directly decrease the target's health.This method bypasses death, causing several errors with other mods, and even the player itself, when the entity falls below 0 health as a result of these mobs attacking.
As such, this PR fixes that by using attackEntityFrom with an armor-bypassing damage source, applying direct damage to the entity while still calling death and other hurt-related actions properly.