Soujuurou/Charlotte/Hakunon/Van Gogh(Miner)/BB Dubai/Ptolemy #1811
+1,636
−462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ArthurKun21
added
the
PR: Awaiting Team consensus
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
ArthurKun21
force-pushed
the
soujuurou
branch
2 times, most recently
from
6d3a4b0
to
e22595b
Compare
updated Soujuurou's command skill
This comment was marked as outdated.
This comment was marked as outdated.
ArthurKun21
removed
the
PR: Awaiting Team consensus
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Closed
1 task
moved the no target below the targets
added images to be loaded for better hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soujuurou/Charlotte/Hakunon/Van Gogh(Miner)/BB Dubai/Ptolemy
Pull Request Type
Related issue
fixes #1841
Description
Added the following servants to the Command Card System:
Introduced new commands to handle future servants with unique skills.
Added the following commands:
[Ch3A]- 3 Choices and Select A option.[Ch3B]- 3 Choices and Select B option.[Ch3C]- 3 Choices and Select C option.All new special targets have special condition that one of the commands must not look like the starting string for another code
For Example
[Ch3A]-> 3 Choices and Select A option.There should be no
[Ch3]command, as having so will create problems when parsing. Already added checker on the code that will throw an error when run on device.Updated the error message when manually entering skill command for more clarity
Screenshots
3 Choices
New Command System in action
Choices (3)Error Message when command does not exist
Updated Look
Skill 1
Skill 2
Skill 3
Hints
Kukulkan
Emiya/BB Dubai
Hakunon/Charlotte/Soujuurou
Van Gogh (Miner)
Space Ishtar
Melusine/Ptolemy
Button Labels
Helps user to know what is the effect of the skill. Defaults to just generic option message.
Emiya/BB Dubai
Hakunon/Charlotte/Soujuurou
Van Gogh (Miner)
Kukulkan
Space Ishtar
Testing
Additional context