-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Commit for Java.util.Date Extension Support + LocalDateTime Unit Test #124
base: 2.17
Are you sure you want to change the base?
Conversation
|
||
public class DateValueReader extends ValueReader { | ||
protected DateValueReader() { | ||
super(Date.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is not JAva 8 date/time type... so probably should be in core jr-objects
?
But also, it needs to support deserialization from Integer numbers (timestamp).
Ok, I think this could use refactoring:
EDIT: ignore this, see my next note. |
Oh shoot. I should have read it more carefully: this ONLY adds textual read/write for I think addition of more features would be ok but should be part of same extension (not separate one) and require configuration (by default leaving serialization as timestamp) -- it's ok to accept textual value by default tho. |
Issue: #48
Providing Support for java.util.Date, via Extensions.