Implement writeRawValue in ToXmlGenerator
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to write 'writteRawValue' code in the same fashion as Json one.
|
Sounds good. Would it be possible to add unit tests to show that this works? One other thing: before merge, we need Contributor Licenses Agreement (CLA): https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf (unless we have asked and gotten one before -- only ever need to be done once) Usual way is to print, fill & sign, scan, email to Looking forward to merging this patch, thank you for submitting it! |
|
Hi, Thanks for quick reply. Looking forward to see this change merged in repo. Kind regards, Yury |
|
Excellent, thank you! Will merge. |
cowtowncoder
changed the title
writeRawValue in ToXmlGenerator
cowtowncoder
added a commit
that referenced
this pull request
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only writeRaw methods are supported.
Default implementation for writeRawValue from GeneratorBase redirects call to writeRaw.
This lead to element name to be ignored which in order leads to invalid XML.
This change will allow to write 'writeRawValue' code in the same fashion as Json one and generating valid XML