force the TimeZone on the custom DateFormat to Settings.getTimeZone() (gh1661) #1665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1661
In summary, the custom DateFormat now has its TimeZone forced to whatever
Settings.getTimeZone()
will return.Update test case to reflect the fixed behavior.
This PR does also contain an additional fix for
withTimeZone(..)
to handle the case where_dateFormat
is null (since this is allowed bywithDateFormat(..)
).