Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msg value refund #20

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Msg value refund #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
268e6d3
removed the is-refund-worth-the-cost check to remove the unaligned in…
thogard785 Oct 20, 2023
43175ac
added a msg value refund when catching execution revert
thogard785 Dec 28, 2023
bc6256e
updated w/ main
thogard785 Dec 29, 2023
848b8b6
bump solc to 0.8.20
jj1980a Jan 4, 2024
caf03c2
comment deprecated function in legacy contract
jj1980a Jan 4, 2024
413c2bf
Target Paris as EVM version, if Solc > 0.8.19
BenSparksCode Jan 4, 2024
54878a4
updated w/ main
thogard785 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion contracts/auction-handler/FastLaneAuctionHandler.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,12 @@ contract FastLaneAuctionHandler is FastLaneAuctionHandlerEvents {
returns (uint256 bidAmount) {
emit RelayFastBid(msg.sender, block.coinbase, true, bidAmount, searcherToAddress);
} catch {
if (msg.value > 0) {
SafeTransferLib.safeTransferETH(
msg.sender,
msg.value
);
}
emit RelayFastBid(msg.sender, block.coinbase, false, 0, searcherToAddress);
}
}
Expand Down Expand Up @@ -513,7 +519,7 @@ contract FastLaneAuctionHandler is FastLaneAuctionHandlerEvents {
limitedReentrant(paymentProcessor)
validPayee
{
if (paymentProcessor == address(0)) revert RelayProcessorCannotBeZero();
if (paymentProcessor == address(0) || paymentProcessor == address(this)) revert RelayProcessorCannotBeZero();

address validator = getValidator();
uint256 validatorBalance = validatorsBalanceMap[validator] - 1;
Expand Down
3 changes: 2 additions & 1 deletion foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ bytecode_hash = "none"
names = true
sizes = true
gas_price = 60000000000
solc_version = '0.8.16'
solc_version = '0.8.20'
evm_version = 'paris'
# See more config options https://github.com/foundry-rs/foundry/tree/master/config
2 changes: 1 addition & 1 deletion lib/openzeppelin-contracts
Open in desktop
Submodule openzeppelin-contracts updated 762 files
2 changes: 1 addition & 1 deletion lib/openzeppelin-contracts-upgradeable
Open in desktop
Submodule openzeppelin-contracts-upgradeable updated 773 files
Loading