Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the SSE41 definition #36

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Correct the SSE41 definition #36

merged 1 commit into from
Dec 29, 2024

Conversation

Genbox
Copy link
Contributor

@Genbox Genbox commented Dec 29, 2024

GCC generates the following definitions:

$ gcc -msse4 -dM -E - < /dev/null | egrep "SSE" | sort
#define __MMX_WITH_SSE__ 1
#define __SSE2_MATH__ 1
#define __SSE2__ 1
#define __SSE3__ 1
#define __SSE4_1__ 1
#define __SSE4_2__ 1
#define __SSE_MATH__ 1
#define __SSE__ 1
#define __SSSE3__ 1

However, several places in the FastFilter source code use __SSE41__. There is a missing underscore. This PR fixes the ifdef to match the ones from GCC. Output is from GCC version 11.4.0.

@lemire lemire merged commit 5df1dc5 into FastFilter:master Dec 29, 2024
1 check passed
@lemire
Copy link
Member

lemire commented Dec 29, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants