Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend TopicConfiguration to support dynamic configuration when creating topics #570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shlomiassaf
Copy link

Description

Dynamic values are valid input when creating a topic.

The PR will allow adding them, so for example, one can provide the retention period and cleanup policy of the topic:

         clusterManager.CreateIfNotExistsAsync("mytopic", 1, 1, new Dictionary<string, string>
          {
              { "retention.ms", (86400000 * 2).ToString() }, // 2 days
              { "cleanup.policy", "delete" }
          });

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant