Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: merge projects into core framework #435

Merged
merged 1 commit into from
Oct 30, 2023
Merged

refactor!: merge projects into core framework #435

merged 1 commit into from
Oct 30, 2023

Conversation

jose-sousa-8
Copy link
Contributor

@jose-sousa-8 jose-sousa-8 commented Sep 19, 2023 •
edited
Loading

Description

  • Removed TypedHandler, Compression, Serializer and BatchConsumer projects
  • Moved the aforementioned projects code to a separated namespace inside the core project
  • Segregated ISerializer and IDeserializer interfaces
  • Segregated ICompressor and IDecompressor interfaces
  • Changed exposed batching extension method from BatchConsume to AddBatching

Fixes #301 #432 #433

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • Need to update v3.0 migration documentation due to high amount of breaking changes in this PR (To be done in a separate PR)

@jose-sousa-8 jose-sousa-8 force-pushed the refactor!/merge-projects branch 4 times, most recently from c07d520 to 5750d76 Compare September 20, 2023 21:05
@joelfoliveira
Copy link
Contributor

I believe this PR is missing the reference to this issue #433

Fixes #301 #432 #433

brmagadutra
brmagadutra reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@brmagadutra brmagadutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Farfetch/kafkaflow/pull/435/files#r1341969932 This discussion is the only point for me pending approval of the PR or not.

@jose-sousa-8 jose-sousa-8 marked this pull request as ready for review October 4, 2023 11:26
erik-catalao
erik-catalao approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@erik-catalao erik-catalao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

filipeesch
filipeesch suggested changes Oct 9, 2023
View reviewed changes
src/KafkaFlow.Serializer.JsonCore/KafkaFlow.Serializer.JsonCore.csproj Outdated Show resolved Hide resolved
src/KafkaFlow.Serializer.NewtonsoftJson/KafkaFlow.Serializer.NewtonsoftJson.csproj Outdated Show resolved Hide resolved
src/KafkaFlow.Serializer.ProtobufNet/KafkaFlow.Serializer.ProtobufNet.csproj Outdated Show resolved Hide resolved
src/KafkaFlow/Middlewares/Compressor/CompressorConsumerMiddleware.cs Outdated Show resolved Hide resolved
src/KafkaFlow/Middlewares/Compressor/CompressorProducerMiddleware.cs Outdated Show resolved Hide resolved
src/KafkaFlow/Middlewares/Serializer/Configuration/ConsumerMiddlewareConfigurationBuilder.cs Outdated Show resolved Hide resolved
src/KafkaFlow/Middlewares/Serializer/Configuration/ProducerMiddlewareConfigurationBuilder.cs Outdated Show resolved Hide resolved
src/KafkaFlow/Middlewares/TypedHandler/Configuration/TypedHandlerConfigurationBuilder.cs Outdated Show resolved Hide resolved
@jose-sousa-8 jose-sousa-8 force-pushed the refactor!/merge-projects branch 2 times, most recently from 17cb6b7 to 896a256 Compare October 25, 2023 13:52
@joelfoliveira joelfoliveira merged commit 07b7cfd into Farfetch:release/3.0 Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailtonguitar ailtonguitar ailtonguitar left review comments

@joelfoliveira joelfoliveira joelfoliveira approved these changes

@erik-catalao erik-catalao erik-catalao approved these changes

@JoaoRodriguesGithub JoaoRodriguesGithub JoaoRodriguesGithub approved these changes

@ruiqbarbosa ruiqbarbosa ruiqbarbosa approved these changes

@brmagadutra brmagadutra brmagadutra approved these changes

@simaoribeiro simaoribeiro simaoribeiro approved these changes

@filipeesch filipeesch filipeesch approved these changes

@gsferreira gsferreira Awaiting requested review from gsferreira

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jose-sousa-8 @joelfoliveira @filipeesch @ailtonguitar @simaoribeiro @brmagadutra @ruiqbarbosa @JoaoRodriguesGithub @erik-catalao